#jython IRC Log

Index

IRC Log for 2015-01-23

Timestamps are in GMT/BST.

[0:26] * mbooth (~mbooth@redhat/mbooth) Quit (Ping timeout: 255 seconds)
[0:40] * mbooth (~mbooth@redhat/mbooth) has joined #jython
[2:11] * robbyoconnor (~wakawaka@guifications/user/r0bby) has joined #jython
[2:21] * r0bby_ (~wakawaka@guifications/user/r0bby) has joined #jython
[2:21] * robbyoconnor (~wakawaka@guifications/user/r0bby) Quit (Ping timeout: 245 seconds)
[2:26] * r0bby_ is now known as robbyoconnor
[2:28] * lopex (uid4272@gateway/web/irccloud.com/x-mlshdjwrurzsilhj) Quit (Quit: Connection closed for inactivity)
[3:32] * fwierzbicki (~Adium@99-106-169-5.lightspeed.sntcca.sbcglobal.net) Quit (Quit: Leaving.)
[3:49] * fwierzbicki (~Adium@2.sub-70-197-12.myvzw.com) has joined #jython
[3:50] * fwierzbicki (~Adium@2.sub-70-197-12.myvzw.com) Quit (Client Quit)
[7:23] * robbyoconnor (~wakawaka@guifications/user/r0bby) Quit (Quit: Konversation terminated!)
[7:23] * r0bby_ (~wakawaka@guifications/user/r0bby) has joined #jython
[9:21] * lopex (uid4272@gateway/web/irccloud.com/x-ctygaobtzqsucbzl) has joined #jython
[10:10] * Paladiamors (~justin@pa9b391.tokynt01.ap.so-net.ne.jp) has joined #jython
[10:36] * siel (~siel@unaffiliated/motley) has joined #jython
[11:28] * plankton (~plankton@177.155.125.70) has joined #jython
[13:07] * xemdetia (xemdetia@nat/ibm/x-qrjhiuxbexedoiax) has joined #jython
[13:34] * plankton (~plankton@177.155.125.70) Quit (Quit: Saindo)
[13:46] <peke> jimbaker: This PR fixes Popen.send_signal (#2219) and Popen.kill (#2220): https://github.com/jythontools/jython/pull/14
[13:47] <peke> I didn't add tests because changes are rather trivial and couldn't find any existing tests for either send_signal or kill.
[13:47] <peke> Can write some if needed.
[13:50] * deepa (deepy@acehack.de) Quit (Changing host)
[13:50] * deepa (deepy@wrongplanet/deepa) has joined #jython
[13:50] * deepa is now known as deepy
[14:07] * clajo04 (~clajo04@pool-74-108-220-163.nycmny.fios.verizon.net) has joined #jython
[14:36] * r0bby_ (~wakawaka@guifications/user/r0bby) Quit (Ping timeout: 244 seconds)
[14:51] * r0bby_ (~wakawaka@guifications/user/r0bby) has joined #jython
[15:04] * enebo (~enebo@c-75-73-8-169.hsd1.mn.comcast.net) has joined #jython
[15:06] * r0bby_ (~wakawaka@guifications/user/r0bby) Quit (Ping timeout: 264 seconds)
[15:25] <jimbaker> peke, but this is being tested by your project, right?
[15:26] <jimbaker> i guess it's fine, but i will see if i can add some testing. not nearly as fun, often can be much harder than the code :)
[15:35] * Paladiamors (~justin@pa9b391.tokynt01.ap.so-net.ne.jp) Quit (Ping timeout: 272 seconds)
[15:37] * zz_gthank is now known as gthank
[15:50] * gthank is now known as zz_gthank
[15:53] * zz_gthank is now known as gthank
[17:13] * fwierzbicki (~Adium@99-106-169-5.lightspeed.sntcca.sbcglobal.net) has joined #jython
[17:18] <peke> jimbaker: Yeah, I tested that all related tests for Robot Framework's Process library pass with those changes. Actually only things that don't work with Jython but work with CPython are related to terminating/killing child processes and sending signals to them. That would require support for preexec_fn=os.setsid (POSIX) and creationflags=subprocess.CREATE_NEW_PROCESS_GROUP (Windows) as well as os.killpg. Most of that apparently just not possible on JVM.
[17:20] <jimbaker> peke, right, unless we do some sort of cpython control package
[17:20] <jimbaker> which would be interesting and doable as a shim library in pypi
[17:20] <peke> jimbaker: I can also write those tests if you want. Would test_subprocess.py or test_subprocess_jy.py be better? Notice that also the former has Jython specific tests..
[17:21] <jimbaker> test_subprocess_jy - they may be tests we would migrate to cpython, but we like to test_subprocess just for patched tests (if any)
[17:21] <jimbaker> be just for
[17:21] <jimbaker> peke, that would be awesome - tests are always better :)
[17:22] <peke> Ok. These tests ought to be fully compatible with CPython and other interpreters.
[17:24] <peke> Except that I probably will use 'python', not sys.executable, as the executable. With Jython sys.executable is a script and thus signals send to self.pid will go only to the script.
[17:24] <peke> Needed to use that approach also earlier when creating tests for Popen.pid.
[17:25] <peke> This also demonstrates why having a native launcher for Jython on all OSes would be so great.
[18:07] * gthank is now known as zz_gthank
[18:10] <peke> jimbaker: `ant regrrest` takes ages. Was there a way to run only test_subprocess_jy?
[18:11] <peke> Ok, found it from https://wiki.python.org/jython/TestingJython.
[18:16] <peke> Actually that didn't work. =/
[18:16] <peke> I tried this:
[18:16] <peke> ant
[18:16] <peke> -> BUILD SUCCESSFUL
[18:16] <peke> dist/bin/jython dist/Lib/test/regrtest.py test_subprocess_jy
[18:17] <peke> -> 1 test OK.
[18:17] <peke> But I ought to have more than one test and one of them has `1/0` and definitely shouldn't pass.
[18:18] <peke> Got to go for a little time. Will investigate later but help prior that would be appreciated too.
[19:38] * xemdetia (xemdetia@nat/ibm/x-qrjhiuxbexedoiax) Quit (Remote host closed the connection)
[19:47] * xemdetia (xemdetia@nat/ibm/x-gxldsfmixfumhvog) has joined #jython
[20:21] * zz_gthank is now known as gthank
[20:32] <jimbaker> peke, yes, the regrtest takes a long long time. you can run dist/bin/jython dist/Lib/test/regrtest.py --verbose test_subprocess_jy
[20:43] * enebo (~enebo@c-75-73-8-169.hsd1.mn.comcast.net) Quit (Quit: enebo)
[21:33] * gthank is now known as zz_gthank
[21:50] <peke> jimbaker: Yeah, figured it out finally. And not the PR is updated with tests. They pass on my Linux and Windows machines.
[22:09] * Paladiamors (~justin@pa9b391.tokynt01.ap.so-net.ne.jp) has joined #jython
[22:21] <jimbaker> peke, nice!
[22:21] <jimbaker> i will take a look and get this merged in asap
[22:23] * Paladiamors (~justin@pa9b391.tokynt01.ap.so-net.ne.jp) Quit (Ping timeout: 245 seconds)
[22:24] * robbyoconnor (~wakawaka@guifications/user/r0bby) has joined #jython
[22:32] <peke> jimbaker: great!
[22:32] <jimbaker> peke, merged. travisci is very handy here
[22:33] <jimbaker> i forgot this was available, i should go through the outstanding PRs on github since at least i know if the PR at least passed tests or not without spending 20 minutes running the regrtest
[22:33] <jimbaker> modern tooling :)
[22:44] <peke> +1 for modern tooling. =)
[22:53] <peke> Most of those PRs look fairly simple.
[22:56] <peke> This one is related to issue I've submitted: https://github.com/jythontools/jython/pull/7
[22:58] <jimbaker> peke, ack - agreed. the other thing is i was hoping that adding committers would get more PRs committed, but so far that hasn't been so easy ;)
[23:00] <jimbaker> jeff raises a good point, however, i believe datetime.py needs to be synced with the actual upstream, which is pypy
[23:00] <jimbaker> pjenvey, still the right place?
[23:01] <peke> Yeah, I noticed that although the fix itself looked simple, apparently it was in wrong place. On a quick look there were some other PRs that looked better in that regard.
[23:02] <jimbaker> another problem that happens...
[23:50] * ebarrett (~edd@88-106-247-216.dynamic.dsl.as9105.com) Quit (Ping timeout: 245 seconds)
[23:51] * xemdetia (xemdetia@nat/ibm/x-gxldsfmixfumhvog) Quit (Ping timeout: 240 seconds)
[23:52] * ebarrett (~edd@host-92-20-128-238.as13285.net) has joined #jython

Index

These logs were automatically created by JythonLogBot on irc.freenode.net using a slightly modified version of the Java IRC LogBot.