Timestamps are in GMT/BST.
[0:02] * enebo (~enebo@65-128-218-235.mpls.qwest.net) has joined #jython
[0:02] * enebo (~enebo@65-128-218-235.mpls.qwest.net) Quit (Client Quit)
[0:03] * enebo (~enebo@65-128-218-235.mpls.qwest.net) has joined #jython
[0:04] * enebo (~enebo@65-128-218-235.mpls.qwest.net) Quit (Client Quit)
[1:42] * stakkars_ (~tismer@p5DDB7C3C.dip.t-dialin.net) has joined #jython
[1:45] * stakkars (~tismer@dslb-088-072-244-176.pools.arcor-ip.net) Quit (Ping timeout: 272 seconds)
[1:45] * stakkars_ is now known as stakkars
[1:51] * stakkars (~tismer@p5DDB7C3C.dip.t-dialin.net) Quit (Remote host closed the connection)
[1:51] * stakkars (~tismer@dslb-088-072-197-062.pools.arcor-ip.net) has joined #jython
[1:59] * stakkars (~tismer@dslb-088-072-197-062.pools.arcor-ip.net) Quit (Ping timeout: 252 seconds)
[2:00] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) has joined #jython
[2:33] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) Quit (Ping timeout: 245 seconds)
[4:47] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) has joined #jython
[4:55] * Arfrever (~Arfrever@apache/committer/Arfrever) Quit (Ping timeout: 252 seconds)
[5:26] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) Quit (Ping timeout: 252 seconds)
[7:14] * stakkars (~tismer@p5DDB7C3C.dip.t-dialin.net) has joined #jython
[8:17] * yanne_ (~jth@backport.reaktor.fi) has joined #jython
[8:23] * wmeissner (~wmeissner@ppp59-167-223-31.static.internode.on.net) has joined #jython
[10:09] * juneau001 (~juneau@50.44.13.106) Quit (Quit: juneau001)
[10:13] * plankton (~peretto@189.73.0.100) has joined #jython
[10:13] * plankton (~peretto@189.73.0.100) Quit (Client Quit)
[11:06] * juneau001 (~juneau@131.225.24.76) has joined #jython
[11:09] * wainersm (~wainersm@189.61.204.85) has joined #jython
[11:18] * juneau001 (~juneau@131.225.24.76) Quit (Read error: Connection reset by peer)
[11:20] * juneau001 (~juneau@131.225.24.76) has joined #jython
[12:22] * Oti (~ohumbel@adsl-84-226-77-191.adslplus.ch) Quit (Quit: Oti)
[12:58] * enebo (~enebo@65-128-218-235.mpls.qwest.net) has joined #jython
[13:53] * stakkars_ (~tismer@i59F771C3.versanet.de) has joined #jython
[15:10] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) has joined #jython
[15:47] * wmeissner_ (~wmeissner@2001:44b8:2134:a102:2ddc:76a0:67a4:50c9) has joined #jython
[15:51] * wmeissner (~wmeissner@ppp59-167-223-31.static.internode.on.net) Quit (Ping timeout: 244 seconds)
[15:51] * wmeissner_ is now known as wmeissner
[15:52] * aquarius1973 (~aquarius1@egress-frr.sf.nat.aol.com) Quit (Remote host closed the connection)
[16:26] * enebo (~enebo@65-128-218-235.mpls.qwest.net) Quit (Quit: enebo)
[16:40] * shashank (~shashank@184-96-142-92.hlrn.qwest.net) Quit (Ping timeout: 240 seconds)
[16:59] * enebo (~enebo@mobile-198-228-204-172.mycingular.net) has joined #jython
[17:23] * shashank (~shashank@ucb-np2-85.colorado.edu) has joined #jython
[17:56] * shashank (~shashank@ucb-np2-85.colorado.edu) Quit (Ping timeout: 248 seconds)
[18:37] <fwierzbicki> Lots of the new test breakage happens because our internal __dict__ is not actually a dict (but a PyStringMap)
[18:37] <fwierzbicki> every time there is a test of the form assertEqual(o.__dict__, ...) we fail
[18:38] <sabi> heh, well hopefully that won't be too bad to fix
[18:39] <sabi> 3.3's got some weird dict optimizations too i thought.
[18:40] <sabi> but i guess that's all still the same type externally
[18:45] * stakkars_ (~tismer@i59F771C3.versanet.de) Quit (Quit: schnarch)
[19:11] <fwierzbicki> sabi: I think for now I'm just going to patch unittest's dict compare - I don't really want to muck with our internal equality testing (at least not today) :)
[19:12] <fwierzbicki> *today* -- or at least end of this week -- I want a regression test that I can trust
[19:12] <sabi> od
[19:12] <sabi> er, nod
[19:18] * stakkars_ (~tismer@f052068026.adsl.alicedsl.de) has joined #jython
[19:19] * stakkars_ (~tismer@f052068026.adsl.alicedsl.de) Quit (Client Quit)
[19:20] * stakkars_ (~tismer@f052068026.adsl.alicedsl.de) has joined #jython
[19:23] * juneau001 (~juneau@131.225.24.76) Quit (Quit: juneau001)
[19:34] * shashank (~shashank@ucb-np2-196.colorado.edu) has joined #jython
[19:53] <jimbaker> fwierzbicki, would it be possible to fix this dict/PyStringMap with __subclasshook__ ?
[19:54] <fwierzbicki> jimbaker: it sounds possible - though I'm doing my best to only do the quickest fixes until I get the regressions passing - I can't take the >100 test class failures anymore :)
[19:54] <jimbaker> certainly the longterm direction going forward is to make __dict__ not actually a true dict, just a view that supports that protocol
[19:54] <jimbaker> fwierzbicki, i'm pretty certain the quickest fix doesn't redo PyStringMap except possibly something like __subclasshook__ ;)
[19:54] <fwierzbicki> jimbaker: agreed - unittest is currently implemented so any dict/dict comparison will ensure that they are both actually dicts - I think unittest is probably overreaching a little
[19:55] <fwierzbicki> so it should probably ensure they are both mappings instead
[19:55] <jimbaker> sounds like a reasonable thing to patch for now
[19:55] <fwierzbicki> but then that depends on what you believe "assertEqauls" means
[19:56] <fwierzbicki> assertEquals even
[19:56] <jimbaker> well it used to mean something more reasonable it would seem :)
[19:57] <fwierzbicki> yeah it worked before :)
[19:57] <fwierzbicki> I think it got lost in trying to make error messages clearer (a noble goal)
[20:02] <jimbaker> ahh, greg smith did this to us. he seems like such a nice guy ;)
[20:03] <jimbaker> anyway, i read the code in assertDictEqual. let's just do the __subclasshook__ support, that should fix this and other bugs out in the wild
[20:43] * Oti (~ohumbel@adsl-89-217-241-25.adslplus.ch) has joined #jython
[20:50] <pjenvey> can't we just fix PyStringMap __eq__ to work against dicts?
[20:55] <pjenvey> don't think subclasshook will help because all the checks don't actually go through the full Python isinstance checks (this code does type.isSubType stuff)
[20:56] * r0bby (~wakawaka@guifications/user/r0bby) has joined #jython
[20:58] * robbyoconnor (~wakawaka@guifications/user/r0bby) Quit (Ping timeout: 244 seconds)
[21:20] * r0bby is now known as robbyoconnor
[21:24] * shashank (~shashank@ucb-np2-196.colorado.edu) Quit (Ping timeout: 245 seconds)
[21:24] * wainersm (~wainersm@189.61.204.85) Quit (Quit: Ex-Chat)
[21:27] <jimbaker> pjenvey, __eq__ won't help here because of the isinstance check in assertDictEqual
[21:27] <jimbaker> but you're right about __subclasshook__, it's more subtle
[21:27] <jimbaker> probably just need to do direct support in instance itself
[21:27] <pjenvey> oh, so assertEqual dispatches to assertDictEqual
[21:28] <jimbaker> pjenvey, right
[21:29] <pjenvey> subclass hook should fix that then, and maybe we would need to fix __eq__ later if other direct comparisons are breaking
[21:30] <pjenvey> I think I added all the ABC machinery already
[21:40] * stakkars_ (~tismer@f052068026.adsl.alicedsl.de) Quit (Quit: schnarch)
[21:58] * wmeissner (~wmeissner@2001:44b8:2134:a102:2ddc:76a0:67a4:50c9) Quit (Remote host closed the connection)
[21:58] * wmeissner (~wmeissner@ppp59-167-223-31.static.internode.on.net) has joined #jython
[22:13] * megaTherion (therion@unix.io) Quit (Read error: Connection reset by peer)
[22:15] * megaTherion (therion@unix.io) has joined #jython
[22:20] * enebo (~enebo@mobile-198-228-204-172.mycingular.net) Quit (Ping timeout: 265 seconds)
[22:22] * r0bby (~wakawaka@guifications/user/r0bby) has joined #jython
[22:23] * robbyoconnor (~wakawaka@guifications/user/r0bby) Quit (Ping timeout: 246 seconds)
[22:23] * r0bby is now known as robbyoconnor
[22:55] * stakkars_ (~tismer@88.130.186.42) has joined #jython
[22:56] * shashank (~shashank@ucb-np2-196.colorado.edu) has joined #jython
[22:58] <fwierzbicki> pjenvey: jimbaker: I agree - we should make stringmap pretend to be a __dict__ for these cases that come up - I'm just doing the quickest thing I see for now.
[22:58] <fwierzbicki> light at the end of the tunnel: I'm finally under the 100 mark for failing test files.
[22:59] <fwierzbicki> I'm getting more and more brutal as I go - but otherwise I'd never get done I fear
[23:08] * srcerer (~chatzilla@dns2.klsairexpress.com) Quit (Quit: ChatZilla 0.9.88 [Firefox 10.0.2/20120215223356])
[23:10] * srcerer (~chatzilla@dns2.klsairexpress.com) has joined #jython
[23:49] * stakkars_ (~tismer@88.130.186.42) Quit (Quit: schnarch)
These logs were automatically created by JythonLogBot_ on irc.freenode.net using a slightly modified version of the Java IRC LogBot (github).